Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update card API endpoint #34

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Fix update card API endpoint #34

merged 4 commits into from
Apr 16, 2020

Conversation

tarunkumar2
Copy link
Contributor

The update card API is throwing an error when called due to some unavailable fields. Have fixed this error by adding the missing fields and made the update card endpoint to run without any error.

For more details about the params in the update card API, please refer: https://developers.circle.com/reference/cards#updatecard

@kristinfritsch
Copy link
Contributor

Unfortunately there are more changes:

  • Added phoneNumber and email to cards/payment metadata object
  • Moved sessionId and ipAddress to be top level properties of metadata

@tarunkumar2 tarunkumar2 mentioned this pull request Apr 15, 2020
Closed
kristinfritsch
kristinfritsch approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@kristinfritsch kristinfritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@kristinfritsch kristinfritsch merged commit 2edfadc into circlefin:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinfritsch kristinfritsch kristinfritsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarunkumar2 @kristinfritsch