Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNTRACKED] Re-enable non-fx fiat payouts #361

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

Wongmat
Copy link
Contributor

@Wongmat Wongmat commented Mar 25, 2024

Related: #360

  • We recently enabled FX fiat payouts but it's disabled regular payouts as if we don't select a toCurrency we attach toAmount: { currency: "" } to the payout request which is invalid
  • This PR fixes this by only attaching toAmount to the request if a toCurrency has been selected
  • FX payout:
Screenshot 2024-03-25 at 11 22 11 AM
  • Regular payout
Screenshot 2024-03-25 at 11 22 26 AM

Signed-off-by: Mat Wong <mat.wong@circle.com>
p12n-circle
p12n-circle previously approved these changes Mar 25, 2024
@feirantonyhu feirantonyhu merged commit a447a26 into circlefin:master Mar 25, 2024
1 check passed
@feirantonyhu feirantonyhu deleted the UNTRACKED/fix-to-amount branch March 25, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants