Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BANK-1376] Remove RTP account endpoints and references #362

Merged

Conversation

ezhang-circle
Copy link
Contributor

@ezhang-circle ezhang-circle commented Apr 22, 2024

Context

Project Context see this doc. This is an onboarding project to clean up deprecated RTP as an account, and make sure RTP still works as a rail type. Changes of this project includes many repos. This PR focuses on the front end changes on Payments Sample App.

This PR

  1. Remove RTP related endpoints from the left side bar menu, and their corresponding references.
  2. Rename 'fiat account type' to 'transfer type' to represent more accurate definition

Testing

yarn build, yarn dev, yarn start to make sure no build/compilation errors

Before

Screenshot 2024-04-22 at 4 49 50 PM

Screenshot 2024-04-22 at 5 36 31 PM

After

Screenshot 2024-04-22 at 4 50 22 PM
Screenshot 2024-04-22 at 5 36 39 PM

Copy link
Contributor

@Wongmat Wongmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezhang-circle
Copy link
Contributor Author

Updated label from 'Fiat account type' to 'Transfer type' as well in this PR.

@Yves-liu Yves-liu merged commit ea2f45d into circlefin:master Apr 23, 2024
1 check passed
@ezhang-circle ezhang-circle deleted the BANK-1376/remove-rtp-account-endpoints branch April 23, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants