Adding settlement APIs and balances API #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, but settlements can be queried by both merchants and marketplaces. Depending on the case, the user needs to specify different parameters. See: https://github.com/circlefin/payment-processor/blob/89fb1ca3a8f000e094af431ad8945aff210e25d8/payment-processor/src/main/java/com/circle/paymentprocessor/resources/v1/SettlementsResource.java#L73-L78 |
kristinfritsch
requested changes
May 13, 2020
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample app doesn't have the APIs for fetching the settlements list and settlement detail. Also the payments API list doesn't have the fetch Balance endpoint.
Adding the above mentioned API to the sample application
Do Not Merge until the API has been added.