Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding reason for cancel and refund payment #48

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Adding reason for cancel and refund payment #48

merged 3 commits into from
Jun 16, 2020

Conversation

tarunkumar2
Copy link
Contributor

@tarunkumar2 tarunkumar2 commented Jun 10, 2020 •
edited
Loading

Do Not Merge Until the API has been updated

The refund and cancel now requires a reason stating why the payment was refunded or cancelled. Adding this param to both payments and marketplace APIs
Screen Shot 2020-06-10 at 5 19 42 PM

@kristinfritsch
Copy link
Contributor

Since the field is not required you should also be able to unselect the reason after selecting one

@kristinfritsch
Copy link
Contributor

I am getting message: "API parameter invalid: Cannot deserialize value of type com.circle.paymentprocessor.model.ReversalReason from String "": was not one of [duplicate, fraudulent, requested_by_customer]". Looks like we need to remove that property from the payload.

@kristinfritsch kristinfritsch merged commit d762e19 into circlefin:master Jun 16, 2020
@tarunkumar2 tarunkumar2 deleted the Add-reason-refund-cancel branch June 16, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinfritsch kristinfritsch kristinfritsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarunkumar2 @kristinfritsch