Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PUT /cards #71

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Conversation

dflorness-circle
Copy link
Contributor

@dflorness-circle dflorness-circle commented Aug 14, 2020

Just reflects that changes made to the endpoint https://developers.circle.com/reference/cards#update-card

Copy link
Contributor

@timmy-circle timmy-circle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kristinfritsch do we have test for each endpoint? I am not very familiar with sample app.

@dflorness-circle dflorness-circle changed the title [BRAAV-2148] Update PUT /cards Update PUT /cards Aug 14, 2020
Copy link
Contributor

@kristinfritsch kristinfritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove unused properties of formData below and cleanup the updateCard api function.

@kristinfritsch
Copy link
Contributor

@timmy-circle we don't have any tests in the sample app. Should be sufficient to test /debug/cards/update manually.

@kristinfritsch kristinfritsch merged commit 4bea4fc into circlefin:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants