[BRAAV-1092] Add page to trigger creation of an incoming wire #76
Conversation
Also made some changes to the chargeback mock endpoint to be consistent with paths used for mock
jcantwell
changed the title
jcantwell
force-pushed
the
incoming_wire_mock
branch
from
60382bd
to
1cce939
Compare
layouts/default.vue
Outdated
| }, | ||
| { | ||
| title: 'POST /mocks/payments/incomingWires', | ||
| to: '/debug/payments/mocks/incomingWire', |
There was a problem hiding this comment.
Would incomingWire makes sense to client if we expose it as api path for mock push payment?
There was a problem hiding this comment.
I though incomingWires would be more understandable than pushPayment but open to suggestions on that one
There was a problem hiding this comment.
discussed offline. Will be using wirePayment this will also help us distinguish with ach
| @@ -1,5 +1,4 @@ | |||
| import chargebacksApi, { | |||
| CreateMockChargebackPayload, | |||
There was a problem hiding this comment.
can also simply remove the bracket here for formatting since we're only importing chargebacksApi
lib/mocksApi.ts
Outdated
| import { getAPIHostname } from './apiTarget' | ||
|
|
||
| export interface CreateMockIncomingWirePayload { | ||
| trackingRefId: string |
There was a problem hiding this comment.
I think trackingRef would suffice. https://github.com/circlefin/platform-eft/blob/01a20ad08ca2bf4cd2212304d9824ca1828707c0/eft/src/main/java/com/circle/eft/external/wires/BankFiatAccountObject.java#L42 Would be nice if we match the response object.
| @@ -90,6 +90,12 @@ | |||
| Refund payment | |||
| </a> | |||
| </p> | |||
| <p v-if="isSandbox"> | |||
There was a problem hiding this comment.
do we need to check isSmokebox as well?
There was a problem hiding this comment.
Nvm, ignore me. I see you checking against isLive().
jcantwell
force-pushed
the
incoming_wire_mock
branch
from
a8a8174
to
17c491f
Compare
Also made some changes to the chargeback mock endpoint to be consistent
with paths used for mock