Separate Marketplace apis out #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristinfritsch
force-pushed
the
marketplace-api-updates
branch
from
2a2c5c0
to
840fc9f
Compare
jcantwell
reviewed
Mar 16, 2020
kristinfritsch
commented
Mar 16, 2020
| @@ -15,18 +15,15 @@ | |||
| </v-list-item-title> | |||
| </v-list-item-content> | |||
| </v-list-item> | |||
| <v-list-item> | |||
There was a problem hiding this comment.
Updates the navigation to use v-list-group and adds a different nav for marketplace api key
kristinfritsch
commented
Mar 16, 2020
| @@ -1,42 +1,29 @@ | |||
| <template> | |||
| <v-app dark> | |||
| <h1 v-if="error.statusCode === 404"> | |||
| {{ pageNotFound }} | |||
There was a problem hiding this comment.
Update error page to show error if wrong route is accessed using a merchant vs marketplace api key
kristinfritsch
commented
Mar 16, 2020
| pageSize: string, | ||
| merchantId: string | ||
| ) { | ||
| const nullIfEmpty = (prop: string) => { |
There was a problem hiding this comment.
Axios omits query params if they are null, not if there are empty strings
jcantwell
reviewed
Mar 16, 2020
jcantwell
previously approved these changes
Mar 16, 2020
jcantwell
previously approved these changes
Mar 16, 2020
kristinfritsch
force-pushed
the
marketplace-api-updates
branch
from
dbe749f
to
c177982
Compare
jcantwell
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate marketplace apis into separate api viewer.