Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose wire instructions for payments/marketplace API #82

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

alandn-circle
Copy link
Contributor

A new endpoint is added for acquiring wire instructions for a bank account (GET /wires/{id}/instructions).

@alandn-circle
Copy link
Contributor Author

Not sure how else I should name my file in pages - considered just using instructions.vue. Is there a better way to name this endpoint re: pages/debug/...?

@timmy-circle
Copy link
Contributor

timmy-circle commented Oct 6, 2020

A minor requst: Would you mind re-order

Screen Shot 2020-10-06 at 11 40 14 AM

to be

POST /wire
GET /wire/:id
GET /wire/:id/instruction

I think that flow would make more sense.

@timmy-circle
Copy link
Contributor

I also verified that it works locally against smokebox. So once you resolve my comment, LGTM.

@timmy-circle
Copy link
Contributor

Not sure how else I should name my file in pages - considered just using instructions.vue. Is there a better way to name this endpoint re: pages/debug/...?

I think it's fine as is.

@kristinfritsch
Copy link
Contributor

Agree with what Timmy said, otherwise looks good!

@kristinfritsch
Copy link
Contributor

I rekicked the PR builder

Copy link
Contributor

@kristinfritsch kristinfritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timmy-circle timmy-circle merged commit b579eae into circlefin:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants