Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALGO to supported chains #85

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Conversation

alandn-circle
Copy link
Contributor

  • Add ALGO as an allowed dropdown value for the path POST /{walletId}/addresses
  • Add the same dropdown to POST /businessAccount/wallets/addresses/recipient
  • Add the same dropdown to POST /businessAccount/wallets/addresses/deposit
  • Add a currency dropdown to POST /businessAccount/wallets/addresses/deposit

@kristinfritsch
Copy link
Contributor

If we add a new blockchain we need to update all places. Maybe we can have a ChainSelector component that is reused across all pages

<ChainSelect
v-model="formData.chain"
label="Chain"
:disabled="loading"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: We don't disable any of the other fields, so I think i want to remove this here too

<ChainSelect
v-model="formData.chain"
label="Chain"
:disabled="loading"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above, remove disable

Copy link
Contributor

@kristinfritsch kristinfritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kristinfritsch kristinfritsch merged commit 292a08f into circlefin:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants