Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destination.type value for Biz Acct Transfers endpoint #99

Merged

Conversation

alandn-circle
Copy link
Contributor

The value being supplied for a POST to create a Biz Acct transfer in the Sample App is incorrect: https://sample-sandbox.circle.com/debug/businessAccount/transfers/create

Specifically, the app supplies a value of address which is not allowed by the destination endpoint:

{
  "idempotencyKey": "7ee50812-4edd-47fb-a78f-7b69c9bbf040",
  "amount": {
    "amount": "10",
    "currency": "USD"
  },
  "destination": {
    "type": "address",
    "addressId": "<SOME_RANDOM_ADDRESS_UUID>"
  }
}

We want to change destination.type to type verified_blockchain to reflect changes on the official Circle API reference, relative to business account transfers as seen here.

Copy link
Contributor

@kristinfritsch kristinfritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the merchant dashboard. I can take care of it.

@kristinfritsch kristinfritsch merged commit f7d4c84 into circlefin:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants