Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web3 dependency #206

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Remove web3 dependency #206

merged 1 commit into from
Aug 20, 2018

Conversation

walkerq
Copy link
Contributor

@walkerq walkerq commented Aug 20, 2018

No description provided.

@walkerq
Copy link
Contributor Author

walkerq commented Aug 20, 2018

@o-a-hudson web3js v0.20.6 doesn't have a method for bytesToHex, and the method toHex was giving the wrong hex output, so I switched it back to v1.0

Copy link
Contributor

@o-a-hudson o-a-hudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be using a beta version in production code. BytesToHex sounds like a standard function. Can you just copy it without changing the version?

Copy link
Contributor

@o-a-hudson o-a-hudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey could you update the title of the PR (w'ere not using the beta anymore) and get rid of that commit in the PR?

@walkerq walkerq changed the title use web3 1.0.0-beta.35 Remove web3 dependency Aug 20, 2018
@o-a-hudson o-a-hudson merged commit a02b53b into circlefin:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants