Basic tests #224
Basic tests #224
Conversation
test/minting/MintP0BasicTests.js
Outdated
| expectedMintControllerState.controllers['controller1Account'] = Accounts.minterAccount; | ||
| await checkMINTp0([token, mintController], [expectedTokenState, expectedMintControllerState]); | ||
|
|
||
| // now set controllers[controller1Account]=arbitraryAccount |
There was a problem hiding this comment.
comment needs to be updated
test/minting/MintP0_ABITests.js
Outdated
| var sendRawTransaction = abiUtils.sendRawTransaction; | ||
| var functionSignature = abiUtils.functionSignature; | ||
| var encodeAddress = abiUtils.encodeAddress; | ||
| var encodeUint = abiUtils.encodeUint; |
There was a problem hiding this comment.
functionSignature, encodeAddress, encodeUint are unused
test/minting/MintP0_ABITests.js
Outdated
| var msgData = abiUtils.msgData; | ||
| var msgData1 = abiUtils.msgData1; | ||
| var msgData2 = abiUtils.msgData2; | ||
| var msgData3 = abiUtils.msgData3; |
There was a problem hiding this comment.
msgData2, msgData3 are unused
| Controller.sol,configureController,controllers[C]=0,bt019,bt019 configureController works when controller[C]=0 | ||
| Controller.sol,configureController,controllers[C] != 0,bt020,bt020 configureController works when controller[C] != 0 | ||
| Controller.sol,configureController,controllers[C]=C,bt021,"bt021 configureController(C,C) works" |
There was a problem hiding this comment.
probably want to remove quotes around descriptions in this csv for consistency
There was a problem hiding this comment.
removed all quotes
There was a problem hiding this comment.
Returned quotes because they are needed. If the description has a comma inside it, then the entire column contents needs to be in quotation marks.
| @@ -205,7 +193,7 @@ function verification_reporter (runner) { | |||
|
|
|||
| // Do not report missing unit tests for files that did not run | |||
| for(var testSuite in missingUnitTests){ | |||
| if(! _.has(executedTestSuites, testSuite) && ! testSuite.match(/Completeness/)) { | |||
| if(! _.has(executedTestSuites, testSuite) /* && ! testSuite.match(/Completeness/)*/) { | |||
There was a problem hiding this comment.
Can you leave a comment on the PR why this change is necessary just to clarify?
|
I modified verification/verification_reporter.js to exclude showing missing Completeness unit tests. It is difficult to write/test single unit test files because in this case ALL tests in the Completeness CSV files will be printed as missing. I created a work-item to fine-tune this script to show missing Completeness unit test units only when testing the whole project. |
Adding unit tests: BasicTests and ABITests