Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of check might lead to gas burn #248

Merged
merged 9 commits into from
Jan 14, 2019
Merged

Lack of check might lead to gas burn #248

merged 9 commits into from
Jan 14, 2019

Conversation

0xj0hnny
Copy link
Contributor

@0xj0hnny 0xj0hnny commented Jan 10, 2019 •
edited
Loading

No description provided.

mirathewhite
mirathewhite suggested changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@mirathewhite mirathewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes in the comments.

test/minting/MintP0_ArgumentTests.js Outdated Show resolved Hide resolved
@eztierney eztierney changed the title Feature/cent 633: Lack of check might lead to gas burn Lack of check might lead to gas burn Jan 11, 2019
@eztierney
Copy link
Contributor

Fixes #253

eztierney
eztierney requested changes Jan 14, 2019
View reviewed changes
ganache-blockchain-log.txt Outdated Show resolved Hide resolved
@mirathewhite mirathewhite merged commit aa862cd into circlefin:multi-issuer Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eztierney eztierney eztierney approved these changes

@mirathewhite mirathewhite mirathewhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xj0hnny @eztierney @mirathewhite