New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeController reverts if controllers[C] is 0 #273

Merged

mirathewhite merged 2 commits into circlefin:multi-issuer from walkerq:remove-controller-check-zero-address

Jan 16, 2019

Contributor

walkerq commented Jan 14, 2019 •

edited

Loading

~~Fixes #264~~ (that was fixed by #247 before me.)


          removeController throws if worker is already zero-address

1323e1e

walkerq force-pushed the remove-controller-check-zero-address branch from b442e4c to 1323e1e Compare

January 16, 2019 17:24


          remove a bunch of unnecessary periods for consistency, fix broken tests

aae241f

Contributor Author

walkerq commented Jan 16, 2019

Adds check that was missing for #252 (ensures that removeController cannot be called if the corresponding worker is already set to address(0)).

mirathewhite approved these changes

View reviewed changes

mirathewhite merged commit 7ad74d7 into circlefin:multi-issuer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet