Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Appveyor PR pipeline with Github Actions #182

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

Stedoss
Copy link
Contributor

@Stedoss Stedoss commented Feb 20, 2024

Super simple pipeline to hopefully replace the older one.

Python 3.9 was picked because it worked, but we can pick another or do a matrix (eg. 3.9, 3.10, 3.11).

Have also updated the tests to reflect the current state of the leaderboards for the tests, but they can be changed/removed if we want.

Requirements for merge:

  • API Key needs to be added to the repo actions secrets.

@tybug
Copy link
Contributor

tybug commented Mar 15, 2024

I've added OSU_API_KEY to this repo's secrets. But I just read this, which might mean this idea is dead in the water....emphasis mine https://github.com/circleguard/circlecore/settings/secrets/actions

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

this is a huge test improvement regardless though, thanks! appveyor definitely needed to go.

@tybug tybug merged commit 998d348 into circleguard:master Mar 15, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants