Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developement #45

Merged
merged 40 commits into from
Feb 4, 2019
Merged

Developement #45

merged 40 commits into from
Feb 4, 2019

Conversation

tybug
Copy link
Contributor

@tybug tybug commented Feb 3, 2019

No description provided.

tybug and others added 30 commits February 1, 2019 14:36
@tybug
implement --verify flag
726eb19
@tybug
catch retrieval failed api response, refactor enum checks
7e3f60e
@tybug
move replay filtering to comparer. Fixes #29
a866127
@tybug
Merge pull request #33 from osu-anticheat/compare-error
7132fcd 
move replay filtering to comparer. Fixes #29
@tybug
Merge pull request #34 from osu-anticheat/dl-error
e300cb5 
catch retrieval failed api response, refactor enum checks
@tybug
Merge pull request #30 from osu-anticheat/verify-redo
463cba7 
implement --verify flag
@tybug
highlight last replay not first
78107f2
@tybug
print username for online replays instead of id
76d5843
@tybug
Merge pull request #35 from osu-anticheat/usernames
12a29f9 
Usernames
@tybug
don't compare when iterator has no elements. Fixes #36
b6d01be
@tybug
Merge branch 'developement' of https://github.com/osu-anticheat/osu-ac …
f73e310 
…into developement
@tybug
remove debug statement
38ae884
@tybug
fix --single flag
239be6e
@tybug
make --single default behavior for -l, force --silent on gui
486d1b7
@tybug
require -n to be at least 2
1175752
@tybug
remove debugging code
e99d09d
@tybug
add --version flag
6c5a87c
@tybug
Merge pull request #38 from osu-anticheat/restrict-mods
82bb2f6 
Restrict mods
@tybug
change default threshold to 18
74cb983
@tybug
Merge branch 'developement' of https://github.com/osu-anticheat/osu-ac …
f440762 
…into developement
@samuelhklumpers
reinsert visualization legend
e0e671c
@samuelhklumpers
fix top n leaderboard label
a00cbd0
@samuelhklumpers
fix fetch <2 or >100 error message
9ecdfd6
@samuelhklumpers
Merge pull request #39 from osu-anticheat/textfixes
dbf904a 
Textfixes
@tybug
raise properly subclassed exception types
ac6fc09
@tybug
fix loading from cache
f75fe9f
@tybug
use specific versions instead of master branches for pip
30c2c6e
@tybug
pass replay_id when creating Replay from cache
72b9f05
@tybug
only attempt to revalidate users actually stored in db
ad55e54
@tybug
Merge pull request #42 from osu-anticheat/compare-fix
209a4db 
Compare fix
trafis
trafis approved these changes Feb 3, 2019
View reviewed changes
Copy link
Contributor

@trafis trafis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor spelling mistake in branch name :) Looks great, thanks for all the hard work as usual!

@samuelhklumpers samuelhklumpers self-requested a review February 3, 2019 16:22
samuelhklumpers
samuelhklumpers approved these changes Feb 3, 2019
View reviewed changes
Copy link
Contributor

@samuelhklumpers samuelhklumpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good, onto v1.1 then

@tybug tybug merged commit c49a278 into master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelhklumpers samuelhklumpers samuelhklumpers approved these changes

@trafis trafis trafis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tybug @cmyui @trafis @samuelhklumpers