Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version of retryablehttp.RequestLogHook change callback signature to use new interface #94

Open
peczenyj opened this issue Jan 3, 2019 · 2 comments

Comments

@peczenyj
Copy link

peczenyj commented Jan 3, 2019

on this commit, go-retryablehttp change some types to use new interfaces

hashicorp/go-retryablehttp@f976417

$ go test -v ./...
# github.com/circonus-labs/circonus-gometrics
./submit.go:144:24: cannot use func literal (type func(*log.Logger, *http.Request, int)) as type retryablehttp.RequestLogHook in assignment

so it is easy to fix via change the type of the first argument

peczenyj added a commit to peczenyj/circonus-gometrics that referenced this issue Jan 3, 2019
focused change to fix issue when used with latest version of `go-retryablehttp/`

see commit hashicorp/go-retryablehttp@f976417
@cgbaker
Copy link

cgbaker commented Apr 5, 2019

Just ran into this as well after needing to update to a later hashicorp/go-retryablehttp.

@maier
Copy link
Member

maier commented Apr 5, 2019

@cgbaker which branch are you using v2 or v3? If you are using master, please use either the v2 (dep) or v3 (go modules) branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants