Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on ipad/safari #3

Open
winkler1 opened this issue Oct 23, 2014 · 7 comments
Open

Does not work on ipad/safari #3

winkler1 opened this issue Oct 23, 2014 · 7 comments
Labels

Comments

@winkler1
Copy link

Needs React.initializeTouchEvents(true) ?

@winkler1
Copy link
Author

Cool game, thanks for doing it!

@cirocosta
Copy link
Owner

Hey @winkler1 ! Thanks!
What do you mean by not working? Nothing happening when clicking on a tile or even when starting?

I can't test this now as i don't have a iOS device right now but i'll surely do later!
Regarding initializeTouchEvents, i'll go deeper in that, but afaik there's currently no support for pointer events which would be great (facebook/react#1389). What do you think?

@winkler1
Copy link
Author

mmm... well, the Start button hilights but the game does not start. In chrome with device emulation, the game starts fine for both iPad and iPhone emulation.

I'm thinking there must a JS error happening, unsupported API or something. Maybe es5-shim. I'll try to add that in and test with it later.

@winkler1
Copy link
Author

Connected to the ipad from Safari to see what's happening on the device... yup, it's http://moduscreate.com/enable-remote-web-inspector-in-ios-6/

Error in main.js#6432. ReferenceError: Can't find variable: Promise

@cirocosta
Copy link
Owner

Oh, thank you so much! @winkler1 . That's comming from the Dispatcher implementation (

Promise.resolve(callback(payload)).then(() => {
)

I'm not polyfilling it nor using a lib, which is causing this issue. I don't have any apple product here, i'd appreciate a bunch if you could test if adding a polyfill (maybe https://github.com/jakearchibald/es6-promise) would make it 😺 . Didn't know either that that was possible with safari, great :)))

@winkler1
Copy link
Author

Throwing this into index.html lets the game start-

<script src=" https://raw.githubusercontent.com/paulmillr/es6-shim/master/es6-shim.js "></script>

Different error now :)
[Error] ReferenceError: Can't find variable: requestAnimationFrame
(main.js, line 20)
[Warning] transition(): tried to perform an animation without an
animationend or transitionend event after timeout (5000ms). You should
either disable this transition in JS or add a CSS animation/transition.
(main.js, line 18)

Are you on a Mac? Perhaps the ipad simulator would help -
http://apple.stackexchange.com/questions/31015/how-do-i-run-the-ipad-simulator-to-test-a-website-on-my-mac,
https://itunes.apple.com/us/app/xcode/id497799835?ls=1&mt=12. Though, I'm
learning by helping track down these errors :)

On Thu, Oct 23, 2014 at 9:09 PM, Ciro S. Costa notifications@github.com
wrote:

Oh, thank you so much! @winkler1 https://github.com/winkler1 . That's
comming from the Dispatcher implementation (

Promise.resolve(callback(payload)).then(() => {

)

I'm not polyfilling it nor using a lib, which is causing this issue. I
don't have any apple product here, i'd appreciate a bunch if you could test
if adding a polyfill (maybe https://github.com/jakearchibald/es6-promise)
would make it [image: 😺] . Didn't know either that that was
possible with safari, great :)))


Reply to this email directly or view it on GitHub
#3 (comment)
.

http://twitter.com/#!/winkler1
Co-organizer, ReactJS Boston http://www.meetup.com/ReactJS-Boston/

@cirocosta
Copy link
Owner

Cool! another thing that's matter of polyfilling. The bad thing is that it will fallback to (setTimeout) loop.
Regarding the second, that's currently a problem with ReactCSSTransitionGroup (as mentioned in facebook/react#1707).

I'm currently on a low-end Linux 😢 hahaha

@cirocosta cirocosta added the bug label Oct 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants