-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix program to work with new dependency versions #426
Conversation
New versions of slugify moved version informations to a standalone module (__verrsion__.py). Added a check to see if the imported version is indeed a string (as previously expected). If not, get the `__version__` variable in the `__version__` module.
https://github.com/ciromattia/kcc/blob/master/requirements.txt slugify >= 3.0.0Duplicate of #411 Pillow >= 8.4.0Duplicate of #406 |
Actually, I tested the changes with the versions specified in requirements.txt on a conversion using |
Also, I'm noticing some inconsistencies in the versions. For example the requirements file specifies a slugify version >=1.2.1 and <3.0.0, but this info does not match the dependency check inside the code ( |
no reason, just an oversight I guess |
merged in #457 |
Thanks a lot! |
The script was crashing in two places due to changes in behaviour of two dependecies (pillow and slugify).
The crash concerning
slugify
was caused by a moved__version__
variable, which in turn caused the script to fail during dependency checks.The crash in PIL was due to a lambda that did not round the returned value to int, thus causing PIL to raise an exception (TypeError float object cannot be interpreted as an integer).