Basic implementation with HTTP/GHA cache protocols, OIDC and Expr #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Jun 23, 2024
Comment on lines
+29
to
+33
| group.GET("/*", cache.get) | ||
| group.HEAD("/*", cache.head) | ||
| group.POST("/*", cache.put) | ||
| group.PUT("/*", cache.put) | ||
| group.DELETE("/*", cache.delete) |
There was a problem hiding this comment.
I think we need some kind of authorization/authentication here? Do we have it somewhere else?
There was a problem hiding this comment.
Do we have it somewhere else?
We have it as a middleware:
chacha/internal/server/server.go
Line 88 in 7f37e5b
fkorotkov
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things still left to be implemented:
attempt to read fallback cache keys and not just the first oneadd a command-line variable tochacha runwith the external base URLneeded by the GHA cache to do a proper redirectGHA cache protocol testResolves https://github.com/cirruslabs/internal-planning/issues/43.