This repository has been archived by the owner on May 8, 2024. It is now read-only.
ShellCommandsAndWait: don't wait for children processes #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
force-pushed
the
dont-wait-for-children
branch
from
93ec572 to
a061dda
Compare
fkorotkov
reviewed
Sep 13, 2021
internal/executor/piper/piper.go
Outdated
| if runtime.GOOS == "windows" { | ||
| result = piper.r.Close() | ||
| } else { | ||
| result = piper.r.SetReadDeadline(time.Now().Add(time.Millisecond * 100)) |
There was a problem hiding this comment.
Do we need to sleep here?
There was a problem hiding this comment.
I guess we can just Close() our end of the pipe, since the process we started has already been Wait()'ed for.
See 0043282.
fkorotkov
reviewed
Sep 13, 2021
internal/executor/piper/piper.go
Outdated
| } | ||
|
|
||
| func (piper *Piper) Close() (result error) { | ||
| // Cancel the Goroutine started in New(): ungracefully Windows and gracefully for other platforms |
There was a problem hiding this comment.
Maybe separate the logic into two smaller method like closeGracefully and closeUngracefully? I think it will be easier to follow the logic
There was a problem hiding this comment.
See 0043282 for a more straightforward logic.
fkorotkov
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves cirruslabs/cirrus-ci-docs#910 by working around golang/go#23019.
This issue was first spotted in #23, however, the PR that fixed it only targets cases where the shell is terminated by a timeout and not cases where the shell has exited cleanly (yet left behind the descendants that referenced it's stderr/stdout file descriptors).