Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Productionize Startlark Configuration #53

Closed
5 tasks done
fkorotkov opened this issue Aug 31, 2020 · 0 comments · Fixed by #122
Closed
5 tasks done

Productionize Startlark Configuration #53

fkorotkov opened this issue Aug 31, 2020 · 0 comments · Fixed by #122
Assignees
@edigaryev

Comments

@fkorotkov
Copy link
Contributor

fkorotkov commented Aug 31, 2020 •
edited by edigaryev
Loading

Basic support for Startlark configuration was added in #48. We still need couple of things in order to productionize Starlark format to align with the vision. Things like:

This will be an issue for tracking overall progress.
edigaryev added a commit that referenced this issue Sep 15, 2020
@edigaryev
Support loading Starlark modules from Git
04bbcae 
See #53.
@edigaryev edigaryev mentioned this issue Sep 15, 2020
Merged
edigaryev added a commit that referenced this issue Sep 16, 2020
@edigaryev
Support loading Starlark modules from Git (#85)
3cc6d50 
* Move loader to a separate package

* Make context available to the loader

* Support loading Starlark modules from Git

See #53.

* Use bounded filesystem wrapper when working with Git

* git.Retrieve(): return more contextualized errors

* Provide a hint when loading of the module that ends with .start fails
edigaryev added a commit that referenced this issue Sep 16, 2020
@edigaryev
Basic GitHub filesystem support
211491b 
A gateway to proper filesystem builtins needed for #53.
@edigaryev edigaryev mentioned this issue Sep 16, 2020
Merged
edigaryev added a commit that referenced this issue Sep 16, 2020
@edigaryev
Basic GitHub filesystem support
9b47b89 
A gateway to proper filesystem builtins needed for #53.
edigaryev added a commit that referenced this issue Sep 16, 2020
@edigaryev
Basic GitHub filesystem support (#89)
ad87b7e 
* Require ctx.Context when calling FileSystem methods

* Move FS implementations to separate packages

* Basic GitHub filesystem support

A gateway to proper filesystem builtins needed for #53.

* Use token if provided

* Handle GitHub API 404 error and return os.ErrNotExist

* Implement TestGetNonExistentFile for local FS
edigaryev added a commit that referenced this issue Sep 17, 2020
@edigaryev
Starlark filesystem builtins
682a928 
See #53.
@edigaryev edigaryev mentioned this issue Sep 17, 2020
Merged
edigaryev added a commit that referenced this issue Sep 18, 2020
@edigaryev
Starlark filesystem builtins (#93)
e4e5142 
* Starlark filesystem builtins

See #53.

* Make fs.FileInfo a struct

* fs.{read,readdir}(): return None's when file or directory does not exist
@edigaryev edigaryev mentioned this issue Sep 20, 2020
Merged
edigaryev added a commit that referenced this issue Oct 1, 2020
@edigaryev
Introduce serve command
db2c967 
See #53.
@edigaryev edigaryev mentioned this issue Oct 1, 2020
Merged
edigaryev added a commit that referenced this issue Oct 2, 2020
@edigaryev
Introduce serve command (#114)
520f64c 
* Introduce serve command

See #53.

* Pick up GitHub-related environment variables and instantiate FS

* Work around unparam linter error

* parser: reference FS instead of files contents map
edigaryev added a commit that referenced this issue Oct 8, 2020
@edigaryev
Starlark documentation
b5e13ce 
Resolves #53.
@edigaryev edigaryev mentioned this issue Oct 8, 2020
Merged
edigaryev added a commit that referenced this issue Oct 8, 2020
@edigaryev
Starlark documentation
c3163c9 
Resolves #53.
edigaryev added a commit that referenced this issue Oct 9, 2020
@edigaryev @fkorotkov
Starlark documentation (#122)
4d163e0 
* Starlark documentation

Resolves #53.

* Update STARLARK.md

Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>

* Update STARLARK.md

Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>

* Update STARLARK.md

Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>

* Update STARLARK.md

Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>

* Update STARLARK.md

Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>

* Update STARLARK.md

Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>

Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edigaryev edigaryev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Starlark documentation cirruslabs/cirrus-cli
2 participants
@edigaryev @fkorotkov