Handle SIGTERM
#834
Merged
Handle SIGTERM
#834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an OOM happening on Cloud Run but we don't capture anything in Sentry. I believe it's because [Cloud Run sends us `SIGTERM`](https://cloud.google.com/run/docs/container-contract#instance-shutdown) and we don't handle it.
fkorotkov
commented
Feb 5, 2025
| @@ -67,7 +68,7 @@ func main() { | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
|
|
|||
| interruptCh := make(chan os.Signal, 1) | |||
| signal.Notify(interruptCh, os.Interrupt) | |||
| signal.Notify(interruptCh, syscall.SIGINT, syscall.SIGTERM) | |||
There was a problem hiding this comment.
Switched to syscall for both for consistency
edigaryev
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an OOM happening on Cloud Run but we don't capture anything in Sentry. I believe it's because Cloud Run sends us
SIGTERMand we don't handle it.