Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Add New Campaign - Source Dropdown #183

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

arniebradfo
Copy link
Collaborator

@arniebradfo arniebradfo commented Sep 15, 2023

Changes

  • Modified NewCampaignDialog.tsx to use an <HTMLSelect/> component instead of <Tabs/>. This approach is more clear for larger numbers of parser options. The Tab bar filled up too quickly.
  • Edited several portions of the custom parser user guide and docs to accommodate the changes:
    • different tabTitle naming convention
    • replace references to "tabs" with references to "dropdown"
    • update screenshot to new UI

Test

@ccarpenter28 & @sang2925

  • This will certainly break tests. Do a global find for create-new-camp to see the cypress bindings that will need to be repaired.
  • One key change: there is no longer a default parser or upload selected. Instead, there is a placeholder message forcing a user to explicitly choose a parser before continuing.
  • Please make sure this works in both RedTeam and BlueTeam Modes

Screenshots

Also see the new parser guide screenshot: custom-parser-upload-tab.png

1
2
3

@sang2925 sang2925 merged commit 622108a into develop Sep 20, 2023
7 checks passed
@sang2925 sang2925 deleted the BLDSTRIKE-601-Add-New-Campaign-Dropdown branch September 20, 2023 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants