Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Presentation Mode - Select Multiple Beacons on Graph and Timeline #187

Merged
merged 14 commits into from
Sep 25, 2023

Conversation

arniebradfo
Copy link
Collaborator

@arniebradfo arniebradfo commented Sep 19, 2023

NOTE: This PR points to #186 not to develop

Changes

  • In presentation mode, when looking at a slide that references multiple beacons, all referenced beacons will appear as selected in the graph, and commands will highlight blue in the timeline
  • This also removes the /:currentItem param from the CAMPAIGN_PRESENTATION_SELECTED router path. This param isn't used to select items anymore
  • HierarchicalGraphData.selectNode() was updated to HierarchicalGraphData.selectNodes() plural and now accepts an array of nodes

Screenshots

Screen Shot 2023-09-19 at 3 02 22 PM

Base automatically changed from presentation-mode-layout-update to develop September 20, 2023 15:03
@ccarpenter28
Copy link
Contributor

@arniebradfo can you merge in develop? The Cypress tests should pass after the latest updates are merged.

@sang2925 sang2925 merged commit 795e36d into develop Sep 25, 2023
7 checks passed
@sang2925 sang2925 deleted the presentation-mode-select-multiple-beacons branch September 25, 2023 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants