This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 276
Update Comment Manual Link UI // Commented Out #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arniebradfo
commented
Mar 9, 2023
}: CheckForAddedLinkProps) => { | ||
const store = useStore(); | ||
|
||
const linkedModel = Array.from(store?.graphqlStore.links.values()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This set the state of its parent component based in a few places.
arniebradfo
changed the title
WIP: Update Comment Manual Link UI
Update Comment Manual Link UI // Commented Out
May 12, 2023
ccarpenter28
approved these changes
May 16, 2023
GoldingAustin
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! THIS PR HAS THE MAJOR CHANGES
// COMMENTED OUT //
!!They'll be reimplemented later in BLDSTRIKE-591
Description
Update the UI and interactions for creating a custom link. There as I was doing this, I've noticed several issues that I'll need help with resolving:
getManualCommandLinks
in CheckForAddedLink.tsx and its usesTesting
Screenshots