Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Update Comment Manual Link UI // Commented Out #91

Merged
merged 24 commits into from
May 23, 2023

Conversation

arniebradfo
Copy link
Collaborator

@arniebradfo arniebradfo commented Mar 9, 2023

!! THIS PR HAS THE MAJOR CHANGES // COMMENTED OUT // !!
They'll be reimplemented later in BLDSTRIKE-591

Description

Update the UI and interactions for creating a custom link. There as I was doing this, I've noticed several issues that I'll need help with resolving:

  • There is no model link between links and annotations or commands. this requires a really unconventional method of turning up the links. See getManualCommandLinks in CheckForAddedLink.tsx and its uses
  • We can't save/edit links in several contexts that we should be able to. Like from a comments tab and really any location that is not a beacon tab. I'd like to understand how and why this is. The rule for allowing a link should be if the annotation has a single command, thus it must be on a single beacon (or maybe even if there are multiple commands that are all on the same beacon. This will have some edge cases that would need to be addressed, so it may not be worth it).
    • I can also currently make a multi-command comment link on a group and this bugs out really bad.
  • Removing a link doesn't work. (my changes caused this)
    • Deleting a comment with a link doesn't delete the link
  • The graph is not restarted with the correct nodes selected
  • The link title/label should really be an annotation title. It also isn't displayed in the graph right now. This can be handled later and is being commented out for now.
  • I can link to the beacon I'm commenting on - ie an self referencing link
  • The CommentBox component is huge and should maybe be refactored...

Testing

  • add, edit and remove a custom link
    • from everywhere that comments exist and are editable
  • beacon suggest search - does it display the right beacons
  • does the link get created and deleted in the graph

Screenshots

Screen Shot 2023-03-09 at 10 42 58 AM
Screen Shot 2023-03-09 at 10 26 16 AM
Screen Shot 2023-03-09 at 10 26 26 AM
Screen Shot 2023-03-09 at 10 39 20 AM

}: CheckForAddedLinkProps) => {
const store = useStore();

const linkedModel = Array.from(store?.graphqlStore.links.values())
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This set the state of its parent component based in a few places.

@arniebradfo arniebradfo marked this pull request as draft March 10, 2023 18:35
@arniebradfo arniebradfo changed the title WIP: Update Comment Manual Link UI Update Comment Manual Link UI // Commented Out May 12, 2023
@arniebradfo arniebradfo marked this pull request as ready for review May 12, 2023 00:22
@arniebradfo arniebradfo merged commit 36fb35b into develop May 23, 2023
@arniebradfo arniebradfo deleted the develop-annotation-updates branch May 23, 2023 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants