Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Initalize-SCuBA from executing on each ScubaGear module import #931

Closed
buidav opened this issue Feb 22, 2024 · 0 comments · Fixed by #946
Closed

Prevent Initalize-SCuBA from executing on each ScubaGear module import #931

buidav opened this issue Feb 22, 2024 · 0 comments · Fixed by #946
Assignees
Labels
enhancement This issue or pull request will add new or improve existing functionality
Milestone

Comments

@buidav
Copy link
Collaborator

buidav commented Feb 22, 2024

💡 Summary

ScubaGear is currently on Import-Module running Initialize-SCuBA, the refactor of .\SetUp.ps1 through Dependencies.ps1 on module import.

ScubaGear should not automatically try to update each time the user imports the module.
The user should be able to update dependencies at the time of their choosing.

Running Initalize-SCuBA on module import also has the side effect of impacting developer efficiency.
For each PowerShell code change the user has to reimport the ScubaGear module to see their changes.
Currently it takes anywhere from 1-2 minutes just to import the module.
Meaning developers will have to wait an additional 1-2 minutes to see their code changes reflected.

ImportTime

Motivation and context

Give users the choice to choose when to update their PowerShell modules.
Restore developer efficiency.

Implementation notes

Modify the Dependencies.ps1 script to not call Initialize-SCuBA by default

Acceptance criteria

Initalize-SCuBA is not called by default when importing the ScubaGear module.

@buidav buidav added the enhancement This issue or pull request will add new or improve existing functionality label Feb 22, 2024
@buidav buidav added this to the Glacier milestone Feb 22, 2024
@crutchfield crutchfield self-assigned this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
2 participants