-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only explicitly install dependencies for Scuba #946
Only explicitly install dependencies for Scuba #946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small documentation change to help with clarity of usage. Change functions as expected and resolves the issue of running setup actions with each import well.
178d41f
to
438537a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one minor suggestion fix for the README.
Also, we should include a section in the README for installing from PowerShell Gallery once the finishing touches are done with that.
Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>
Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>
Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>
f7435e9
to
f1408bd
Compare
@nanda-katikaneni PR ready to merge to main. Smoke test failure is for know g3 tenant issue. |
🗣 Description
Change ScubaGear module to not automatically install dependencies. Checks if they are missing on import and advised user to use Initialize-SCuBA to add them.
closes #931
💭 Motivation and context
The import of Scuba caused dependencies to be checked/installed each time it is imported. This check took time (<2 minute) that impacts testing.
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist