-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference URL to ScubaResults.json #1119
Conversation
Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update works as intended. Existing group links still work, and group reference URL is shown to be available in the ScubaResults.json when Invoke-Scuba
is run with -MergeJSON
as expected.
Minor recommendation to make var more specific, but approving as it is not a critical path change. If there is time to update, test, and verify though, please do so.
Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>
Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>
@nanda-katikaneni Ready for merge |
🗣 Description
Add the link to the group markdown anchor (see screenshot) to the ScubaResults.json file.
![image](https://private-user-images.githubusercontent.com/106177711/334866329-e5978b19-587d-4117-8b2b-11aac4a7dfcb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk4NDE4ODQsIm5iZiI6MTczOTg0MTU4NCwicGF0aCI6Ii8xMDYxNzc3MTEvMzM0ODY2MzI5LWU1OTc4YjE5LTU4N2QtNDExNy04YjJiLTExYWFjNGE3ZGZjYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxOFQwMTE5NDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lZjllY2EwNGE0MTRhMmY3NzQ4MGE5MmYyMjRkMWU0MGQ3MWZkOTZkZmI3MmY0YTU3Yjg4YjAzNzQ1NWQ3YzMzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.RabO9Iuq8NQCtQntv6RZR2kpvdSXRQrWFFm59fp-65A)
💭 Motivation and context
Closes #1118.
🧪 Testing
Ran against a test tenant and verified that both the links in the HTML and the links in the json worked as expected.
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist