Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference URL to ScubaResults.json #1119

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented May 29, 2024

🗣 Description

Add the link to the group markdown anchor (see screenshot) to the ScubaResults.json file.
image

💭 Motivation and context

Closes #1118.

🧪 Testing

Ran against a test tenant and verified that both the links in the HTML and the links in the json worked as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@adhilto adhilto added the enhancement This issue or pull request will add new or improve existing functionality label May 29, 2024
@adhilto adhilto added this to the Halibut milestone May 29, 2024
@adhilto adhilto requested review from buidav and schrolla May 29, 2024 16:05
@adhilto adhilto self-assigned this May 29, 2024
@adhilto adhilto linked an issue May 29, 2024 that may be closed by this pull request
1 task
Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>
@buidav buidav self-requested a review May 29, 2024 16:39
Copy link
Collaborator

@schrolla schrolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update works as intended. Existing group links still work, and group reference URL is shown to be available in the ScubaResults.json when Invoke-Scuba is run with -MergeJSON as expected.
Minor recommendation to make var more specific, but approving as it is not a critical path change. If there is time to update, test, and verify though, please do so.

adhilto and others added 2 commits May 29, 2024 13:02
Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>
Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>
@adhilto
Copy link
Collaborator Author

adhilto commented May 29, 2024

@nanda-katikaneni Ready for merge

@nanda-katikaneni nanda-katikaneni merged commit 2cd6c19 into main May 30, 2024
14 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 1118-group-reference-url branch May 30, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Group Reference URL in ScubaResults.json
4 participants