-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import path for Support Initialize-SCuBA #1363
Fix import path for Support Initialize-SCuBA #1363
Conversation
A more complete fix for overall module issues is documented in #1347 . This PR addresses the immediate associated smaller issue. |
Feature branch currently fails functional testing workflow due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error seems to be gone from both the release package import
via terminal and the PSGallery install.
Functional tests are unaffected by this change (still some failures with SharePoint but that's unrelated to this issue).
Good to go.
Re-ran failed functional tests to validate that they were due to unrelated intermittent failures. All functional tests are now green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I wasn't able to recreate the error now!
@nanda-katikaneni The bug fix has been thoroughly reviewed and tested and is ready for merge. |
🗣 Description
Add fixes to resolve the error that is thrown during an
Initiailze-SCuBA
cmdlet run after installing ScubaGear from its nuget package (via PSGallery).💭 Motivation and context
Prevents extraneous error and red text from being thrown during ScubaGear initialization.
Closes #1361
🧪 Testing
Install-Module -Name ScubaGear -AllowPrerelease -RequiredVersion 1.4.0-test2024101002
(note: this module version corresponds to a packaging of the PR fix branch)Initialize-SCuBA
and review output for presence of red text shown in screenshot below.📷 Screenshots (if appropriate)
Showing the issue when present (the red text should not be present in the fix)
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist