-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Defender license warnings for policy groups 2 and 4 #929
Enhanced Defender license warnings for policy groups 2 and 4 #929
Conversation
1e35219
to
dc3dc6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The licensing relationship to policy group 4, particularly 4.2 is a bit more granular and tricky than just adding a warning. This might require some additional thinking about how best to report status on a policy item that contains a mix of both license required and non-license required items. Technically, without the license a tenant cannot meet the requirement, but without details about specific locations the admin doesn't have sufficient feedback to determine if the issue is due to license, DLP policy config, or a combination of both. See full comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting closer, but recommend additional code to better delineate which locations are not meeting the baseline rather than a generic message. See comments below.
PowerShell/ScubaGear/Testing/Unit/Rego/Defender/DefenderConfig_04_test.rego
Outdated
Show resolved
Hide resolved
PowerShell/ScubaGear/Testing/Unit/Rego/Defender/DefenderConfig_04_test.rego
Outdated
Show resolved
Hide resolved
PowerShell/ScubaGear/Testing/Unit/Rego/Defender/DefenderConfig_04_test.rego
Outdated
Show resolved
Hide resolved
PowerShell/ScubaGear/Testing/Unit/Rego/Defender/DefenderConfig_02_test.rego
Outdated
Show resolved
Hide resolved
PowerShell/ScubaGear/Testing/Unit/Rego/Defender/DefenderConfig_04_test.rego
Show resolved
Hide resolved
Also added fix for powershell bugs #976 |
1a644f8
to
9b00f72
Compare
f996684
to
81f2021
Compare
PowerShell/ScubaGear/Testing/Unit/Rego/Defender/DefenderConfig_04_test.rego
Outdated
Show resolved
Hide resolved
b952bc7
to
ccafb10
Compare
ccafb10
to
6d0ab73
Compare
* Add DLP license warning details for Teams and Devices * Update unit tests to handle message changes
* Add tests that show fail when license not present in G3
* Remove invalid test test_Locations_Incorrect_V9
06246ed
to
621d1a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally works great.
Biggest issue is to fix the new dlp_license
key naming.
PowerShell/ScubaGear/Modules/Providers/ExportDefenderProvider.psm1
Outdated
Show resolved
Hide resolved
PowerShell/ScubaGear/Modules/Providers/ExportDefenderProvider.psm1
Outdated
Show resolved
Hide resolved
Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@nanda-katikaneni This PR is ready for merge. |
🗣 Description
Add licenses check for policy groups 2 and 4 in addition to the current check, make the report details more precise. And let user be more aware of the missing licenses.
💭 Motivation and context
closes #599
🧪 Testing
Run Scuba for Defender
Change the json file mainly "defender_license" to "false"
Run Scuba for Defender again
Will see warning about Defender license missing during the run
Will see notes on reports indicates license missing
Note: the check for policy group 2 and 4 will still pass or fail based on the environment setting because we are modifying the json file from an tenant with required licenses. The result is still be accurate based on the environment information. Note that, normally it will fail if they don't have license due to missing information from the provider JSON.
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist