Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphan PowerShell unit test #956

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

crutchfield
Copy link
Contributor

@crutchfield crutchfield commented Mar 1, 2024

🗣 Description

Removed orphaned unit test.
closes #955

💭 Motivation and context

Moved all unit test to be packaged with module as per MS best practice recommendation.

🧪 Testing

  • Executed PowerShell unit test, all passed,

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@crutchfield crutchfield added the bug This issue or pull request addresses broken functionality label Mar 1, 2024
@crutchfield crutchfield added this to the Glacier milestone Mar 1, 2024
@crutchfield crutchfield self-assigned this Mar 1, 2024
@crutchfield crutchfield linked an issue Mar 1, 2024 that may be closed by this pull request
@crutchfield crutchfield force-pushed the 955-move-orphan-unit-test-to-proper-location branch 2 times, most recently from be2cb90 to acde778 Compare March 6, 2024 15:51
Copy link
Contributor

@isab-m isab-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and all tests passed.

@crutchfield
Copy link
Contributor Author

@nanda-katikaneni PR is ready to merge to main

@crutchfield crutchfield force-pushed the 955-move-orphan-unit-test-to-proper-location branch from d635711 to 03c120e Compare March 8, 2024 12:46
@nanda-katikaneni nanda-katikaneni merged commit 78ae309 into main Mar 11, 2024
14 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 955-move-orphan-unit-test-to-proper-location branch March 11, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move orphan unit test to proper location
4 participants