-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated regal to latest version #964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like minor changes for a language version update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changed and ran Invoke-Scuba
which worked as intended with latest release. However, noted that changing import rego.v1 and removing if {}
statements has the effect of making versions of Rego <0.59 fail as the syntax is not supported by earlier versions of the engine. I am okay with requiring newer versions, but it means we should also update the list of allowed OPA rego engine versions in the Install-OPA method to only support 0.59 and up (0.60 and 0.61 at the moment).
Recommend updating allowed list by removing those now unsupported versions. Also recommend rebase first as the allow list has been updated by a now merged commit.
5f37020
to
6748ef9
Compare
Change to allow tested version 59-61. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything still works as expected, except for the comment below.
de48fc7
to
98d66ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed latest updates and found that it installed the latest version of OPA running both Initialize-SCuBA
and Install-OPA
as expected. No other issues found and looks ready for merge.
@nanda-katikaneni PR is ready to merge to main |
🗣 Description
Updated regal to use latest version - update uses Node 20+
closes #917
💭 Motivation and context
Node 16 is no longer supported with security updates
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist