-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path to required version data #969
Fix path to required version data #969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested fix by running Initialize-SCuBA
from the checkout repo directory, from its grandparent directory, and reviewing the nightly testing action taken previously. Also ran Invoke-SCuBA
to ensure it ran as expected and it did.
Code review shows update to ModuleBaseDir as a solid location from which to base calculation of the RequiredVersions.ps1 relative script location. See requested change below for minor updates for it to function properly in workflow scenarios.
Please add the
|
7a2a513
to
a410e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for good work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated code works when tested in both the expected and error condition cases. Ran Invoke-Scuba
successfully on test tenant and ran Initialize-SCuBA
successfully. Renamed RequiredVersions.ps1 and ran again and received expected error condition. Looks good to me.
@nanda-katikaneni PR is ready to merge to main. Smoke test failure unrelated to PR. |
🗣 Description
Identify module base dir and get RequirementVersions.ps1 relative to that instead of relying on $PSScriptRoot
closes #968
💭 Motivation and context
Initialize-SCuBA was failing to find RequiredVersions.ps1 when executed from a owrkflow running.
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist