Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the ScubaGoggles Reporter to a Class #166

Closed
1 task
Tracked by #164
buidav opened this issue Jan 26, 2024 · 0 comments · Fixed by #342
Closed
1 task
Tracked by #164

Convert the ScubaGoggles Reporter to a Class #166

buidav opened this issue Jan 26, 2024 · 0 comments · Fixed by #342
Assignees
Milestone

Comments

@buidav
Copy link
Collaborator

buidav commented Jan 26, 2024

💡 Summary

This issue is to track work in converting the ScubaGoggles reporter into a class.
Tied to epic #164

Motivation and context

There should no longer be a reason to tie ScubaGoggles design to mimic ScubaGear's design.
The current design decision to model ScubaGoggles after ScubaGear was for ease of portability of features from over there.
Converting Reporter to a class will help clean up the tangled code and provide better extendibility.

Implementation notes

Multiple functions in the reporter are playing parameter juggling due to the current when refactored to a class. Most of these variables can be replaced with state variables.

Acceptance criteria

  • reporter.py is converted into a Class.
@buidav buidav added this to the Backlog milestone Jan 26, 2024
@adhilto adhilto modified the milestones: Coast, Backlog Jun 18, 2024
@snarve snarve modified the milestones: Backlog, Coast Jul 3, 2024
@rlxdev rlxdev self-assigned this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants