Reporter: convert to class implementation (issue 166) #342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
I converted the reporter module to a class. It’s instantiated by the Orchestrator class in the
run_reporter()
method. There are a few methods in the reporter that format HTML independent of the instance, so these are implemented as static methods.If you’re reviewing the changes, it’ll be easier to compare this class implementation with the non-class module while ignoring whitespace and empty lines.
💭 Motivation and context
closes #166
🧪 Testing
I've tested these changes by running several different variations of ScubaGoggles runs. All runs I've done were successful. Nearly all changes were associated with converting the reporter functions to class methods, so there weren't any functional changes to the code that would cause any problems.
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and merge
button.✅ Post-merge Checklist