Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Report Details for GWS.GMAIL.7.6 #295

Closed
adhilto opened this issue May 29, 2024 · 0 comments · Fixed by #394
Closed

Full Report Details for GWS.GMAIL.7.6 #295

adhilto opened this issue May 29, 2024 · 0 comments · Fixed by #394
Assignees
Labels
bug This issue or pull request addresses broken functionality Code review Gmail
Milestone

Comments

@adhilto
Copy link
Collaborator

adhilto commented May 29, 2024

🐛 Summary

Currently (as of #278), the report details for GWS.GMAIL.7.6 doesn't always show the full picture.

To reproduce

See #294 for discussion on a related applicable issue.

@adhilto adhilto added the bug This issue or pull request addresses broken functionality label May 29, 2024
@adhilto adhilto added this to the Coast milestone May 29, 2024
@snarve snarve self-assigned this May 30, 2024
snarve added a commit that referenced this issue Aug 27, 2024
snarve added a commit that referenced this issue Aug 27, 2024
snarve added a commit that referenced this issue Aug 28, 2024
snarve added a commit that referenced this issue Aug 30, 2024
snarve added a commit that referenced this issue Sep 5, 2024
snarve added a commit that referenced this issue Sep 10, 2024
snarve added a commit that referenced this issue Sep 10, 2024
snarve added a commit that referenced this issue Sep 10, 2024
adhilto pushed a commit that referenced this issue Sep 11, 2024
…f spoofing and authentication settings that are not complaint (#394)

* [#295] Update policy 7

* [#295] Update policy 7 to handle multiple settings detailed report message

* [#295] Cleanup

* [#295] Update 7.6 and 5.5

* [#295] Update policy 5 and 7

* [#295] Format the report output

* [#295] Fix formatting for policy 7 and rename variables with more logical names

* [#295] Rename policy 5 and 7 variables and formatting updates

* [#295] Unit tests updated

* [#294] Fix linter issues

* [#294] Linter formatting

* [#294] More formatting

* [#295] Try different format for linter

* [#295] Remove if statement

* [#295] Use different assignment operator

* [#295] Update assignment operator for policy 5

* Linter fix

* More linter fixes

* Linter formatting

* Linter again

* Update array format

* Remove comma

* Remove array notation

* Replace assignment operator

* Refactor functions

* Typo fixed

* [#396] Updated the criticality for policy 5.5

* [#397] Update criticality for policy 7.6

* PR updates

* Remove typo

* Update message for setting

* Update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality Code review Gmail
Projects
None yet
2 participants