Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Groups 7.1 #489

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Removing Groups 7.1 #489

merged 2 commits into from
Nov 4, 2024

Conversation

mdueltgen
Copy link
Collaborator

@mdueltgen mdueltgen commented Oct 31, 2024 •
edited
Loading

🗣 Description

Removing Groups 7.1 policy

💭 Motivation and context

Closese #273

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@mdueltgen mdueltgen added this to the Driftwood milestone Oct 31, 2024
@mdueltgen mdueltgen self-assigned this Oct 31, 2024
@mdueltgen mdueltgen linked an issue Oct 31, 2024 that may be closed by this pull request
Reevaluate the benefits of Groups 7.1 #273
Closed
1 task
buidav
buidav approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhilto removed Groups.7 from the rego.
@mdueltgen if any other changes need to be made, pull the branch first.

@adhilto adhilto merged commit 22e7d74 into main Nov 4, 2024
11 checks passed
@adhilto adhilto deleted the 273-reevaluate-the-benefits-of-groups-7.1 branch November 4, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buidav buidav buidav approved these changes

@adhilto adhilto adhilto approved these changes

Assignees

@mdueltgen mdueltgen

Labels
Baseline Revision Groups
Projects
None yet
Milestone
Driftwood
Development

Successfully merging this pull request may close these issues.

Reevaluate the benefits of Groups 7.1
3 participants
@mdueltgen @buidav @adhilto