Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set permissions explicitly in .yaml files so GITHUB_TOKEN only has what's necessary #2999

Closed
2 tasks
h-m-f-t opened this issue Oct 28, 2024 · 0 comments
Closed
2 tasks

Set permissions explicitly in .yaml files so GITHUB_TOKEN only has what's necessary #2999

h-m-f-t opened this issue Oct 28, 2024 · 0 comments
Assignees
@Matt-Spence
Labels
carryover Carryover from a previous sprint dev

Comments

@h-m-f-t
Copy link
Member

h-m-f-t commented Oct 28, 2024 •
edited by abroddrick
Loading

Issue description

We're changing the default GITHUB_TOKEN permissions at the org level. Here is some context on why we are making this change. This issue tracks the per-repo work to make updates to our .yaml files. If you find that each repo requires multiple PRs, create a new subissue for each PR.

Acceptance criteria

  • Complete the sub-issues
  • Update our developer documentation to note that any new .yaml files for Actions should define necessary permissions

Additional context

see example at https://github.com/cisagov/skeleton-generic/pull/190/files

Links to other issues

See https://github.com/orgs/cisagov/discussions/31
@h-m-f-t h-m-f-t moved this from 👶 New to ⚙ Dev Parking Lot in .gov Product Board Oct 28, 2024
@PaulKuykendall PaulKuykendall moved this from ⚙ Dev Parking Lot to 🎯 Ready in .gov Product Board Oct 29, 2024
@PaulKuykendall PaulKuykendall moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Oct 29, 2024
@PaulKuykendall PaulKuykendall added the carryover Carryover from a previous sprint label Nov 12, 2024
@Matt-Spence Matt-Spence moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Nov 12, 2024
@Matt-Spence Matt-Spence self-assigned this Nov 12, 2024
This was referenced Nov 12, 2024
Closed
Merged
Matt-Spence added a commit that referenced this issue Nov 14, 2024
@Matt-Spence
Merge pull request #3073 from cisagov/ms/2999-add-monitor-to-workflows
13d61fa 
#2999: add monitor to workflows - MS
@Matt-Spence Matt-Spence moved this from 🏗 In progress to ✅ Done in .gov Product Board Nov 18, 2024
@Matt-Spence Matt-Spence closed this as completed by moving to ✅ Done in .gov Product Board Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matt-Spence Matt-Spence

Labels
carryover Carryover from a previous sprint dev
Projects
.gov Product Board
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@h-m-f-t @Matt-Spence @PaulKuykendall @vickyszuchin