Add community.docker as a requirement for molecule testing
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We explicitly add the `community.docker` collection with a minimum version as a requirement to the molecule configuration. This will allow us to ensure that a version of this collection that is compatible with 2.32.0 and newer of the Python requests library is installed.
mcdonnnj
added
bug
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
1 task
jsf9k
approved these changes
May 30, 2024
mcdonnnj
added
the
kraken 🐙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds the community.docker collection with a specified minimum version as an explicit requirement for our molecule scenario.
💭 Motivation and context
Without version 3.10.2 of the community.docker collection our molecule testing cannot pass on a fresh install. The latest version of ansible has version 3.10.1 of the community.docker collection and we need a minimum of version 3.10.2 to ensure compatibility with the requests library version 2.32.0 and newer. The next release will not be until next month (June of 2024) and we are still awaiting the merge of ansible-community/molecule-plugins#257 which would ensure 3.10.2 is the minimum version installed for the Docker driver.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
in code comments.