Add a lower bound for the version of setuptools #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
blocked
This is done in response to a recently-discovered vulnerability in setuptools: - https://security.snyk.io/vuln/SNYK-PYTHON-SETUPTOOLS-3113904 - pypa/setuptools#3659 - https://cwe.mitre.org/data/definitions/1333.html
jsf9k
force-pushed
the
security/lower-bound-for-setuptools
branch
from
51fa6d7
to
c149b76
Compare
|
I'm not sure about investing in version pinning this kind of dependency simply because a fresh install or an upgrade install will pull down the appropriate package, the vulnerability is a self-DoS, and the new version is not specifically required for functionality. If we do want to proceed with this kind of pinning then we need to add an ignore directive (with attribution0 here skeleton-generic/.github/dependabot.yml Lines 23 to 26 in e803e1a in line with how we manage other pinned dependencies. |
|
Closed due to @mcdonnnj's compelling argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a lower bound for the version of setuptools.
💭 Motivation and context
This is done in response to a recently-discovered vulnerability in setuptools:
It should also get rid of a zillion Snyk PRs like this that are polluting our repos.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist