Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.6 #134

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Drop support for Python 3.6 #134

merged 2 commits into from
Jul 29, 2024

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Mar 12, 2024 •
edited
Loading

🗣 Description

This pull request drops support for Python 3.6.

💭 Motivation and context

Although it's helpful to support older versions as long as possible it no longer makes sense to support this version of Python given the following:

  • Python 3.6 reached end-of-life on 2021-12-23.
  • The oldest supported version of Python is 3.8.
  • The oldest Python we need support for is 3.7.
    • This is because 3.7 is the version of Python 3 available on Debian Buster.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number python Pull requests that update Python code labels Mar 12, 2024
@mcdonnnj mcdonnnj self-assigned this Mar 12, 2024
jsf9k
jsf9k approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Au revoir, Ricky Bobby. Au revoir.

@jsf9k jsf9k requested a review from a team March 12, 2024 14:19
dav3r
dav3r approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hasta la vista Py3.6!

@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Mar 13, 2024
@mcdonnnj mcdonnnj added this pull request to the merge queue Jul 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 29, 2024
@mcdonnnj
Drop support for Python 3.6
3c741d2 
Python 3.6 reached end-of-life on 2021-12-23. Since the oldest version
of Debian that we use (Debian Buster) provides Python 3.7 we can safely
sunset support for this version of Python.
@mcdonnnj
Bump version from 0.2.0 to 0.2.1
111eac0
@mcdonnnj mcdonnnj force-pushed the improvement/drop_support_for_py3.6 branch from 5f0b559 to 111eac0 Compare July 29, 2024 21:32
@mcdonnnj mcdonnnj added this pull request to the merge queue Jul 29, 2024
Merged via the queue into develop with commit 272917a Jul 29, 2024
58 checks passed
@mcdonnnj mcdonnnj deleted the improvement/drop_support_for_py3.6 branch July 29, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release python Pull requests that update Python code version bump This issue or pull request increments the version number
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @dav3r @dv4harr10