Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CI from Travis to GitHub actions #20

Merged
merged 20 commits into from
Oct 18, 2019
Merged

Switch CI from Travis to GitHub actions #20

merged 20 commits into from
Oct 18, 2019

Conversation

felddy
Copy link
Member

@felddy felddy commented Oct 17, 2019

Switch from using Travis for CI, to GitHub actions.

Just a few notes for additional work:

There is still some work to be done with regards to detecting releases and the associated pytests.

It would be something like this:

  if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags')

See: https://github.com/pypa/gh-action-pypi-publish

@felddy
Add a actions workflow similar to the travis config.
a68f7e8
@felddy
Change python version to 3.8
585d43b
@felddy
Revert to python 3.7
bba0aa5
@felddy
Work around pre-commit issue.
dd0e2f7 
See: pypa/setuptools#1869
@felddy
Fix install_requires syntax.
47dc280
@felddy
Update pre-commit config to lastest versions.
083f9da
@felddy
Remove setuptools pinning.
efda8d5 
This is an ansible lint issue: 
ansible/ansible-lint#590
@felddy
Apply workaround for ansible-lint error.
ca38016 
See: ansible/ansible-lint#590
@felddy
Add special sauce for coveralls.
1b30c8d 
See: https://github.com/marketplace/actions/coveralls-github-action
@felddy
Add config to tell coveralls where the coverage file lives.
28c6ada
@felddy
Fix syntax error. Learning is fun!
91d0164
@felddy
Switch to using coveralls with token.
9c6b5e4
@felddy
Rename workflow and add badge to README.
c6d4d5f
@felddy
Correct capitalization for badge.
ff27a9a
@felddy
Make action badge a link.
58c707d
@felddy
Lowercasing workflow name so the shield matches all others.
f8ca5c6
@felddy
Remove travis. :(
da7e1cc
@felddy
Add comment about why we are pinning virtualenv
e666a6f
@felddy
Rename env variable to make sense in a post-travis world.
e4127dd
@felddy
Formatting
038a75a
@felddy felddy self-assigned this Oct 17, 2019
jsf9k
jsf9k approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

mcdonnnj
mcdonnnj approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm digging these changes and the extra headroom we'll get in concurrent checks with the migration. LGTM 👍

@felddy felddy merged commit fae7694 into develop Oct 18, 2019
@felddy felddy deleted the improvement/actions branch October 18, 2019 00:42
felddy added a commit that referenced this pull request Nov 15, 2019
@felddy
Merge pull request #20 from cisagov/improvement/actions
12b91c4 
Replace Travis-CI with GitHub actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

Assignees

@felddy felddy

Labels
None yet
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felddy @jsf9k @mcdonnnj