Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort the Package Requirements in setup.py #59

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Sort the Package Requirements in setup.py #59

merged 2 commits into from
Nov 18, 2020

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 13, 2020 •
edited
Loading

🗣 Description

This PR simply makes sure the packages in the install_requires and extras_requires["test"] arguments are sorted.

💭 Motivation and Context

Having requirements sorted (as long as order is not important) makes it easier to track what is required.

🧪 Testing

Automated tests pass without issue.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
Make sure the requirements in setup.py are sorted
a9ee3dd 
Sort the install_requires and extras_require["test"] arguments by key.
jsf9k
jsf9k approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

dav3r
dav3r approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! 🦅 👁️

@mcdonnnj mcdonnnj self-assigned this Nov 15, 2020
hillaryj
hillaryj approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

cisagovbot pushed a commit that referenced this pull request Nov 18, 2020
@jsf9k
Merge pull request #59 from cisagov/improvement/get-python-version-mo…
3b312c4 
…re-simply

Use the python version output by actions/setup-python
@mcdonnnj mcdonnnj merged commit a8bdbe5 into develop Nov 18, 2020
@mcdonnnj mcdonnnj deleted the sort_requirements branch November 18, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@hillaryj hillaryj hillaryj approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @hillaryj @dav3r