Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Block-Style Sequence for Python Versions in build Workflow #83

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR changes the sequence of Python versions to use for the test and build jobs to use block-style instead of flow-style formatting.

💭 Motivation and context

This improves the readability and makes any changes to supported versions a discrete change.

🧪 Testing

With these changes in place the jobs run (and pass) as they did before.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Switch from a flow style to a block style sequence in the build workflow. This
will improve maintainability by making version changes impact one Python
version at a time.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jul 31, 2021
@mcdonnnj mcdonnnj self-assigned this Jul 31, 2021
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate flow style for this very reason! It's less readable!

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catch the flow! 🏄

@mcdonnnj mcdonnnj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Aug 3, 2021
@mcdonnnj mcdonnnj merged commit e21a2a8 into develop Aug 26, 2021
@mcdonnnj mcdonnnj deleted the improvement/gha_python_version_block_style_sequence branch August 26, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Development

Successfully merging this pull request may close these issues.

3 participants