Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support Python 3.10 #93

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request marks the Python package as officially supporting Python 3.10.

💭 Motivation and context

In #87 we added testing and building for Python 3.10 but did not mark the Python package as supporting Python 3.10 (oops!).

⚠ Note

This work is currently included in #90, but after thinking about it more I would like to enable Python 3.10 support and terminate 3.6 support as separate tasks (with different versioning).

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Add a tag or create a release.

This was missed when we added testing/building for Python 3.10.
@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Feb 28, 2022
@mcdonnnj mcdonnnj self-assigned this Feb 28, 2022
@mcdonnnj mcdonnnj requested a review from jsf9k as a code owner February 28, 2022 19:58
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐍

@mcdonnnj mcdonnnj merged commit 2092099 into develop Mar 7, 2022
@mcdonnnj mcdonnnj deleted the improvement/add_official_py3.10_support branch March 7, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Development

Successfully merging this pull request may close these issues.

3 participants