Add support for publishing homebrew-tap recipe #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chive Add binaries to release archive
* Publish binaries in tar.gz/zip format also * Configure brew in goreleaser * Use publisher token for goreleaser
…shing-brew-tap # Conflicts: # .goreleaser.yml
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 32.08% 32.08%
=======================================
Files 27 27
Lines 3597 3597
=======================================
Hits 1154 1154
Misses 2352 2352
Partials 91 91 |
This reverts commit 3aaf513.
* Revert to using latest goreleaser * Update goreleaser version in Makefile to fix ci
Neo2308
commented
Jul 12, 2023
| @@ -35,9 +35,10 @@ jobs: | |||
| - name: Run GoReleaser | |||
| uses: goreleaser/goreleaser-action@v3 | |||
| with: | |||
| version: latest | |||
| version: 'v1.18.2' | |||
There was a problem hiding this comment.
Latest version (at the time of writing) is v1.19.2 and it needs extra keys. The changes are incompatible with older versions of goreleaser and goreleaser 1.19.2 requires go 1.20 so the ci breaks. So, for now I have set the goreleaser version to v1.18.2
Will take up the go version update separately and change this back to latest.
pnickolov
approved these changes
Jul 12, 2023
GDW1
pushed a commit
to GDW1/fsoc
that referenced
this pull request
Jul 13, 2023
* Add binaries to release archive * Add support for publishing homebrew-tap recipe * Publish binaries in tar.gz/zip format also * Configure brew in goreleaser * Use publisher token for goreleaser * Try publishing to experimental repo * Use separate tokens for publishing binaries and tap * Fix usage of tap token. * Fix tap token env variable. * Raise PR in tap repo. * Specify branch for PR * Try publishing to cisco open experimental tap. * Apply brew test bot suggestion * Update tap repo name * Remove tap token * Revert "Remove tap token" This reverts commit 3aaf513. * Fixed deprecated key * Attempt publish to experimental repo * Enable debug logging for goreleaser * Revert go releaser version to v1.18.2 * Change goreleaser flag --verbose -> --debug * Cleanup * Remove debug logging from goreleaser * Change tap repo homebrew-experimental -> homebrew-tap * Revert to using latest goreleaser * Revert to using latest goreleaser * Update goreleaser version in Makefile to fix ci * Fixing ci * Change goreleaser version in Makefile to v1.18.2 to fix ci * Fixing ci * Revert deprecated key for now. * Fixing ci * Use goreleaser v1.18.2 for now. --------- Co-authored-by: RadhaKrishna <radha.peteti@appdynamics.com>
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist