FSOC-37 Added argument support to fsoc config set
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 32.34% 32.09% -0.26%
==========================================
Files 27 27
Lines 3568 3596 +28
==========================================
Hits 1154 1154
- Misses 2323 2351 +28
Partials 91 91
|
pnickolov
approved these changes
Jul 9, 2023
GDW1
pushed a commit
to GDW1/fsoc
that referenced
this pull request
Jul 10, 2023
* FSOC-37 Added argument support to * fixed deprecation messages, fixed documentation examples --------- Co-authored-by: GDW1 <guwilks@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing FSOC-37
Before you were only able to provide values for the config file through flags (i.e. "--auth oauth"). Now you can provide values for the config file through arguments (i.e. "auth=oauth")
This is closer to
git configstyleThis is done with little refactoring to the existent code and all changes still support the old way of supplying values (which can be mixed and matched i.e. "auth=oauth --url URL")
Type of Change
Checklist