Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp to profiler report query #136

Conversation

linkous8
Copy link
Contributor

Description

Resolves an issue where warnings were printed and profiler reports were not being included in output. This was caused by a change in UQL where the timestamp is no longer automatically included in results. The fix is to explicitly query for the timestamp where needed (note this does not apply to the optimize configure command as that was not checking for/using the timestamp column)

Also includes addition of -v logging of the workloadId corresponding to the report being processed

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

- Enhance logging of profiler report processing
@linkous8 linkous8 requested a review from pnickolov as a code owner June 30, 2023 17:32
@codecov-commenter
Copy link

Codecov Report

Merging #136 (c5f2775) into main (62d908f) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   32.34%   32.34%           
=======================================
  Files          27       27           
  Lines        3568     3568           
=======================================
  Hits         1154     1154           
  Misses       2323     2323           
  Partials       91       91           

@pnickolov pnickolov merged commit 0bde820 into cisco-open:main Jul 3, 2023
7 checks passed
GDW1 pushed a commit to GDW1/fsoc that referenced this pull request Jul 10, 2023
- Enhance logging of profiler report processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants